Attention is currently required from: dexter, fixeria, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34444?usp=email )
Change subject: write_queue: Enable updating max_length field
......................................................................
Patch Set 4:
(2 comments)
File src/core/write_queue.c:
https://gerrit.osmocom.org/c/libosmocore/+/34444/comment/612963d2_25e0991b
PS3, Line 161: queue->current_length > queue->max_length
This condition can never be true because you're
updating the `queue->max_length` after the loop, not […]
Done
File tests/write_queue/wqueue_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/34444/comment/3dca4dd2_33cd74ca
PS3, Line 98: OSMO_ASSERT
Somehow this `assert()` does not assert at all, no
matter how I change the expected value. […]
Ah heck, I fixed it locally for the
previous test code I added before uploading and somehow managed to recode this error right
again *facepalms*. Thanks
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34444?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibfe51a2faf29f8ae160a9c330c9af0d09b5a9002
Gerrit-Change-Number: 34444
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Sep 2023 15:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment