Attention is currently required from: dexter, fixeria, pespin.

View Change

2 comments:

• File src/core/write_queue.c:

  • Patch Set #3, Line 161: queue->current_length > queue->max_length

    This condition can never be true because you're updating the `queue->max_length` after the loop, not […]

    Done

• File tests/write_queue/wqueue_test.c:

  • Patch Set #3, Line 98: OSMO_ASSERT

    Somehow this `assert()` does not assert at all, no matter how I change the expected value. […]

    Ah heck, I fixed it locally for the previous test code I added before uploading and somehow managed to recode this error right again *facepalms*. Thanks

To view, visit change 34444. To unsubscribe, or for help writing mail filters, visit settings.