Attention is currently required from: fixeria, dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )

Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ......................................................................

Patch Set 4:

(2 comments)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/33690/comment/72190f20_2f433eab PS4, Line 31: base class

Do we want to make it an abstract base class (`@abc. […]

possibly, I'm not entirely sure which way this will develop. In general, the entire 'CardBase + subclasses' here in the non-legacy module has very little functionality, the real work is in SmartCardCommands (which is also ugly as it mixes commands for SIM + UICC in one class, ...).

https://gerrit.osmocom.org/c/pysim/+/33690/comment/9d1f4fc8_c0be856c PS4, Line 41: self._aids = []

unreachable code

thanks, this should be in the constructor.