Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 )
Change subject: Add bsc_nat fsm ......................................................................
Patch Set 9:
(3 comments)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/22c3cdee_67f3a3b2 PS8, Line 129: ss7_inst_free(bsc_nat->cn);
Ack, agree with Pau.
(Fixed in patchset 9.)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/a3fb6bfd_c7a2188c PS9, Line 96: talloc_free
osmo_ss7_instance_destroy() does talloc_free(inst), so no need to free() it again.
I'm running osmo_ss7_instance_destroy on "ss7", not on "inst".
File src/osmo-bsc-nat/main.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/adf588ca_33829b71 PS8, Line 148: if (g_bsc_nat->shutdown)
Can you explain why are you changing this? […]
On second thought, the whole ->shutdown doesn't really make sense here. Removed and using osmo_select_shutdown_requested() again.
-
osmith