Attention is currently required from: pespin, fixeria.

View Change

3 comments:

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #8, Line 129: ss7_inst_free(bsc_nat->cn);

    Ack, agree with Pau.

    (Fixed in patchset 9.)

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #9, Line 96: talloc_free

    osmo_ss7_instance_destroy() does talloc_free(inst), so no need to free() it again.

    I'm running osmo_ss7_instance_destroy on "ss7", not on "inst".

• File src/osmo-bsc-nat/main.c:

  • Patch Set #8, Line 148: if (g_bsc_nat->shutdown)

    Can you explain why are you changing this? […]

    On second thought, the whole ->shutdown doesn't really make sense here. Removed and using osmo_select_shutdown_requested() again.

To view, visit change 26662. To unsubscribe, or for help writing mail filters, visit settings.