Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28869 )
Change subject: BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,ass_updown}() ......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28869/comment/b6dd0d32_079b4... PS2, Line 2968: var octetstring l2 := f_pad_oct('010349'O & '0615004001C0'O, 21, '00'O);
I think this list of numbers needs some more explanation.
I agree. also, it looks like the same magic numbers are used multple times, that might warrant something like a 'const octetstring' value with a self-explanatory name.