Attention is currently required from: pespin, fixeria.
View Change
1 comment:
File bts/BTS_Tests.ttcn:
Patch Set #2, Line 2968: var octetstring l2 := f_pad_oct('010349'O & '0615004001C0'O, 21, '00'O);
I think this list of numbers needs some more explanation.
I agree. also, it looks like the same magic numbers are used multple times, that might warrant something like a 'const octetstring' value with a self-explanatory name.
To view, visit change 28869. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad
Gerrit-Change-Number: 28869
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Aug 2022 10:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment