Attention is currently required from: pespin.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email )
Change subject: coverity CID#358071 ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/osmo-hnbgw/hnbgw_hnbap.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996/comment/e3a5b744_6ecd15dc?us... : PS1, Line 657: cause.present = HNBAP_Cause_PR_protocol;
probably better to do here: […]
hehe this is a great moment in history, there have been days where i had to fight fierce battles in support of this struct assignment notation =)
If this were new code, I'd write it exactly as you suggest, but here i prefer a small patch size / less surface for merge conflicts; note, there is another use of 'cause' below.
The effect of our two variants is identical, it's a bikeshed.
-
neels