Attention is currently required from: pespin.

Patch set 1:Code-Review +2

View Change

1 comment:

• File src/osmo-hnbgw/hnbgw_hnbap.c:

  • Patch Set #1, Line 657: cause.present = HNBAP_Cause_PR_protocol;

    probably better to do here: […]

    hehe this is a great moment in history, there have been days where i had to fight fierce battles in support of this struct assignment notation =)

    If this were new code, I'd write it exactly as you suggest, but here i prefer a small patch size / less surface for merge conflicts; note, there is another use of 'cause' below.

    The effect of our two variants is identical, it's a bikeshed.

To view, visit change 37996. To unsubscribe, or for help writing mail filters, visit settings.