Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 ) Change subject: abis_om2000: move switch-case to function ...................................................................... Patch Set 2: (4 comments) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/9d616c3e_a8adb091 PS1, Line 964: oml_avstate_from_om2k_mostate Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/6e594a99_5be912e9 PS1, Line 997: switch (mo->class) { Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/4e50cb90_dd571a7b PS1, Line 1016: oml_opstate_from_om2k_opstate Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/8d93e84e_3d5f657d PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state) I am not sure about the naming scheme. "abis" is one layer below. As far as I understand om2k is also on top of abis. The real difference is between OM2K and OML. Du you have a suggestion for a better function name? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 10:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment