Attention is currently required from: fixeria, pespin.

View Change

4 comments:

• File src/osmo-bsc/abis_om2000.c:

  • Patch Set #1, Line 964: oml_avstate_from_om2k_mostate

    static?

    Done

  • Patch Set #1, Line 997: switch (mo->class) {

    You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a […]

    Done

  • Patch Set #1, Line 1016: oml_opstate_from_om2k_opstate

    static?

    Done

  • Patch Set #1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)

    it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't yo […]

    I am not sure about the naming scheme. "abis" is one layer below. As far as I understand om2k is also on top of abis. The real difference is between OM2K and OML.

    Du you have a suggestion for a better function name?

To view, visit change 28914. To unsubscribe, or for help writing mail filters, visit settings.