Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32269 ) Change subject: bts/oml: Repurpose test TC_ipa_rsl_connect_nack ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32269/comment/e8f16b02_18e5… PS2, Line 9: it is fine for the BTS to ACK : the RSL CONNECT despite later on failing to connect the RSL link Are you really sure? You're saying it's just setting the attributes, but in reality `rx_oml_ipa_rsl_connect()` does call `e1inp_ipa_bts_rsl_connect_n()` and checks the return value. You're also saying that "it can be replaced with SETATTR in the future", but I don't see how given that it's an ip.access specific message and this is what nanoBTS expects. I don't remember all the details, but I think I wrote this testcase looking at how nanoBTS behaves in such situations. Can you re-test and clarify its behavior? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32269/comment/db56e5f2_acac… PS2, Line 23: Change-Id: I10df611f0086d34a5482f7c8a79703938313ab3d Related: OS#5964 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10df611f0086d34a5482f7c8a79703938313ab3d Gerrit-Change-Number: 32269 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Apr 2023 16:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment