Attention is currently required from: iedemam, neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )

Change subject: stats: new trackers for lchan life duration ......................................................................

Patch Set 15:

(4 comments)

Patchset:

PS15: None of my comments are critical.

File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/8e14a261_6da1ddeb PS14, Line 465: struct rate_ctr *active_ms_rate_ctr; You could simply set it to NULL here and keep the code unchanged, but not critical.

File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/874f508b_31637b45 PS15, Line 465: uint Is it a valid type from <stdint.h>? Never saw it before. I would expect to see 'unsigned int' here instead.

https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/8d02321d_53a18588 PS15, Line 478: counter_id = -1; This should go to the 'default' branch of the 'switch' statement below.