Attention is currently required from: iedemam, neels, laforge, pespin.

View Change

4 comments:

• Patchset:

  • Patch Set #15:

    None of my comments are critical.

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #14, Line 465: struct rate_ctr *active_ms_rate_ctr;

    You could simply set it to NULL here and keep the code unchanged, but not critical.

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #15, Line 465: uint

    Is it a valid type from <stdint.h>? Never saw it before.
    I would expect to see 'unsigned int' here instead.

  • Patch Set #15, Line 478: counter_id = -1;

    This should go to the 'default' branch of the 'switch' statement below.

To view, visit change 27081. To unsubscribe, or for help writing mail filters, visit settings.