[M] Change in libosmo-netif[master]: ipa: Add segmentation callback - gerrit-log

1 Aug 2023


      Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 )
Change subject: ipa: Add segmentation callback
......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/bdbbddee_f7af1784 
PS5, Line 26: #define OSMO_IPA_MSGB_CB(__msg)	((struct osmo_ipa_msgb_cb *)&((__msg)->cb[0]))
with latest version of the patch I still see an ilogical prefix here:
OSMO_IPA_MSGB_CB vs osmo_ipa_msgb_proto (should be osmo_ipa_msgb_cb_proto).
The "cb" part imho is important when reading because it allows understanding where the proto comes from.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I87ef4c7023126b783dd79e7ed47be31e1b76f975
Gerrit-Change-Number: 33652
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Tue, 01 Aug 2023 17:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment