Attention is currently required from: arehbein, laforge.

View Change

1 comment:

• File include/osmocom/netif/ipa.h:

  • Patch Set #5, Line 26: #define OSMO_IPA_MSGB_CB(__msg) ((struct osmo_ipa_msgb_cb *)&((__msg)->cb[0]))

    with latest version of the patch I still see an ilogical prefix here:
    OSMO_IPA_MSGB_CB vs osmo_ipa_msgb_proto (should be osmo_ipa_msgb_cb_proto).
    The "cb" part imho is important when reading because it allows understanding where the proto comes from.

To view, visit change 33652. To unsubscribe, or for help writing mail filters, visit settings.