Change in libosmo-abis[master]: ipa: Guard against calling ipa_client_conn_open* multiple times - gerrit-log

16 Dec 2022


      Attention is currently required from: osmith.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30618 )
Change subject: ipa: Guard against calling ipa_client_conn_open* multiple times
......................................................................
Patch Set 2:
(1 comment)
File src/input/ipa.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30618/comment/a45b5d80_3415d3f4 
PS2, Line 253: 		return -EINVAL;
...
maybe log an error message?
I don't think here's the right place. We return other errors without logging below as well and the places that call ipa_client_conn_open(2) usually log failures.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30618
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I574af543429d01c9522e267265e97e4efe55b60c
Gerrit-Change-Number: 30618
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Fri, 16 Dec 2022 17:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment