Attention is currently required from: osmith.
View Change
1 comment:
File src/input/ipa.c:
Patch Set #2, Line 253: return -EINVAL;
maybe log an error message?
I don't think here's the right place. We return other errors without logging below as well and the places that call ipa_client_conn_open(2) usually log failures.
To view, visit change 30618. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I574af543429d01c9522e267265e97e4efe55b60c
Gerrit-Change-Number: 30618
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 17:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Gerrit-MessageType: comment