Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32406 ) Change subject: ts_51_011: fix EF_ServiceTable: use self for static method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Using class name to access own methods breaks inheritance: if you define a child class and redefine the `_bit_byte_offset_for_service()` in it, the `_encode_bin()` would still be using parent's version. It was my initial plan to add a child class for `EF_CST` and I faced this problem, but then I figured out that it uses the same encoding as `EF_SST`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3590dda341d534deb1b7f4743ea31ab16dbd6912 Gerrit-Change-Number: 32406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 07:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment