Attention is currently required from: pespin.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I see no point in passing self if it's static.

    Using class name to access own methods breaks inheritance: if you define a child class and redefine the `_bit_byte_offset_for_service()` in it, the `_encode_bin()` would still be using parent's version. It was my initial plan to add a child class for `EF_CST` and I faced this problem, but then I figured out that it uses the same encoding as `EF_SST`.

To view, visit change 32406. To unsubscribe, or for help writing mail filters, visit settings.