Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30266 )

Change subject: paging: Store list of gsm_paging_request in bsc_subscr ......................................................................

Patch Set 3:

(2 comments)

File include/osmocom/bsc/bsc_subscriber.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/57d92ebd_799a3902 PS2, Line 57: gsm_paging_request

IMO, it's better to have all forward declarations in one place (above).

In general yes, but for this one I preferred keeping it here with the subset of functions specifically working with paging_request. I doubt it will be needed in another set of APIs.

File src/osmo-bsc/bsc_subscriber.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/dda7bcdc_81d07f7f PS3, Line 270: it could be freed during put():

JFYI: the usual way to avoid this is would be: […]

I don't see the point in doing that here, that adds extra get/put which also triggers allocations, logging, etc. Why recounting if it's not needed, adding a specific refcount here of whatever type just makes the use_count of the struct more difficult to understand.