Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30266 ) Change subject: paging: Store list of gsm_paging_request in bsc_subscr ...................................................................... Patch Set 3: (2 comments) File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/57d92ebd_799a3902 PS2, Line 57: gsm_paging_request In general yes, but for this one I preferred keeping it here with the subset of functions specifically working with paging_request. I doubt it will be needed in another set of APIs. File src/osmo-bsc/bsc_subscriber.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/dda7bcdc_81d07f7f PS3, Line 270: it could be freed during put(): I don't see the point in doing that here, that adds extra get/put which also triggers allocations, logging, etc. Why recounting if it's not needed, adding a specific refcount here of whatever type just makes the use_count of the struct more difficult to understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I831d0fe01d7812c34500362b90f47cd65645b666 Gerrit-Change-Number: 30266 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 18:51:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment