Attention is currently required from: fixeria.

View Change

2 comments:

• File include/osmocom/bsc/bsc_subscriber.h:

  • Patch Set #2, Line 57: gsm_paging_request

    IMO, it's better to have all forward declarations in one place (above).

    In general yes, but for this one I preferred keeping it here with the subset of functions specifically working with paging_request. I doubt it will be needed in another set of APIs.

• File src/osmo-bsc/bsc_subscriber.c:

  • Patch Set #3, Line 270: it could be freed during put():

    JFYI: the usual way to avoid this is would be: […]

    I don't see the point in doing that here, that adds extra get/put which also triggers allocations, logging, etc.
    Why recounting if it's not needed, adding a specific refcount here of whatever type just makes the use_count of the struct more difficult to understand.

To view, visit change 30266. To unsubscribe, or for help writing mail filters, visit settings.