Attention is currently required from: keith, pespin.

laforge has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )

Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ......................................................................

Patch Set 6:

(1 comment)

File src/osmo-bsc/bts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/66308872_a28be3bc?usp=... : PS6, Line 769: return I'm not such a big fan of functions unconditionally returning zero, especially if the caller doesn't check the return value anyway.

I think we either a) anticipate that future versions of that function might fail, in which case the callers should already check for non-zero return values, or

b) have void-returning functions and continue with no checks at the calling site