Attention is currently required from: keith, pespin. laforge has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/66308872_a28be3bc?usp… : PS6, Line 769: return I'm not such a big fan of functions unconditionally returning zero, especially if the caller doesn't check the return value anyway. I think we either a) anticipate that future versions of that function might fail, in which case the callers should already check for non-zero return values, or b) have void-returning functions and continue with no checks at the calling site -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 6 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 26 Aug 2025 08:40:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No