Attention is currently required from: keith, pespin.

View Change

1 comment:

• File src/osmo-bsc/bts.c:

  • Patch Set #6, Line 769: return

    I'm not such a big fan of functions unconditionally returning zero, especially if the caller doesn't check the return value anyway.

    I think we either
    a) anticipate that future versions of that function might fail, in which case the callers should already check for non-zero return values, or

    b) have void-returning functions and continue with no checks at the calling site

To view, visit change 40917. To unsubscribe, or for help writing mail filters, visit settings.