Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC ......................................................................
Patch Set 1:
(4 comments)
File contrib/sima-response-tool.py:
https://gerrit.osmocom.org/c/pysim/+/40936/comment/ef39092f_02ef0a29?usp=ema... : PS1, Line 57: 8 : 'template-not-supported', : 9 : 'feature-not-supported', ```suggestion 8 : 'lib-not-supported', 9 : 'template-not-supported', ```
https://gerrit.osmocom.org/c/pysim/+/40936/comment/a8664bda_356868c9?usp=ema... : PS1, Line 74: propritary ```suggestion return "%d = %04x (proprietary)" % (status, status) ```
(same typo in other places in this file)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/cc8717fb_99af552b?usp=ema... : PS1, Line 77: return "%d (unknown, propritary?)" % (status, status) contrib/sima-response-tool.py:77:11: E1305: Too many arguments for format string (too-many-format-args)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/7a0dd315_06111ac3?usp=ema... : PS1, Line 93: if euicc_response_decoded.get('profileInstallationAborted', False) is None: Is comparing against `is None` correct here? I wonder if it should be compared against `is True` as the print then says `True`.