Attention is currently required from: dexter.

View Change

4 comments:

• File contrib/sima-response-tool.py:

  • Patch Set #1, Line 57:

                         8 : 'template-not-supported',
                         9 : 'feature-not-supported',
    

    ```suggestion
                         8 : 'lib-not-supported',
                         9 : 'template-not-supported',
    ```

  • Patch Set #1, Line 74: propritary

    ```suggestion
            return "%d = %04x (proprietary)" % (status, status)
    ```

    (same typo in other places in this file)

  • Patch Set #1, Line 77: return "%d (unknown, propritary?)" % (status, status)

    contrib/sima-response-tool.py:77:11: E1305: Too many arguments for format string (too-many-format-args)

  • Patch Set #1, Line 93: if euicc_response_decoded.get('profileInstallationAborted', False) is None:

    Is comparing against `is None` correct here? I wonder if it should be compared against `is True` as the print then says `True`.

To view, visit change 40936. To unsubscribe, or for help writing mail filters, visit settings.