Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 ) Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ...................................................................... Patch Set 3: (2 comments) File include/osmocom/hlr/db.h: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/cb81afa1_f4b73297 PS2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation. yes. Since after this patch the code is now only using sub_auth_data2, there is no usage of osmo_sub_auth_data left, and hence the comment would refer to an unused struct type if it's not changed here. File src/db_hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/96f03b91_4e930295 PS2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) { you are correct, this belongs into Ibbde68484c904507a15c35cbfdf88cd47d0c7039 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2 Gerrit-Change-Number: 33097 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 13:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment