Attention is currently required from: neels.

View Change

2 comments:

• File include/osmocom/hlr/db.h:

  • Patch Set #2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation.

    intentional rename? is sub_auth_data_str also used for osmo_sub_auth_data2?

    yes. Since after this patch the code is now only using sub_auth_data2, there is no usage of osmo_sub_auth_data left, and hence the comment would refer to an unused struct type if it's not changed here.

• File src/db_hlr.c:

  • Patch Set #2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) {

    (this patch intends no change of length, right?)

    you are correct, this belongs into Ibbde68484c904507a15c35cbfdf88cd47d0c7039

To view, visit change 33097. To unsubscribe, or for help writing mail filters, visit settings.