Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34133 )

Change subject: layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind ......................................................................

Patch Set 6:

(4 comments)

Patchset:

PS6: Looks good to me in general, just a few not critical comments.

File src/host/layer23/src/modem/grr.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/448abfc4_81ddde02 PS6, Line 98: uint32_t fn = *(uint32_t *)(&msg->cb[0]); also const like below?

https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/14c03d31_df03db42 PS6, Line 210: FN=%u BCCH message (type=0x%02x) Please move the `Fn=%u` inside the braces to have consistent formatting:

``` BCCH message (type=0x%02x, Fn=%u): %s ```

https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/a8bee4b4_39597614 PS6, Line 381: memcpy Doing `memcpy` is not really needed, right?

``` const uint8_t *val = TLVP_VAL(&tv, RSL_IE_OSMO_ABS_FRAME_NUMBER); *(uint32_t *)(&msg->cb[0]) = osmo_load32be(val); ```