Attention is currently required from: jolly, pespin.

View Change

4 comments:

• Patchset:

  • Patch Set #6:

    Looks good to me in general, just a few not critical comments.

• File src/host/layer23/src/modem/grr.c:

  • Patch Set #6, Line 98: uint32_t fn = *(uint32_t *)(&msg->cb[0]);

    also const like below?

  • Patch Set #6, Line 210: FN=%u BCCH message (type=0x%02x)

    Please move the `Fn=%u` inside the braces to have consistent formatting:

    ```
    BCCH message (type=0x%02x, Fn=%u): %s
    ```

  • Patch Set #6, Line 381: memcpy

    Doing `memcpy` is not really needed, right?

    ```
    const uint8_t *val = TLVP_VAL(&tv, RSL_IE_OSMO_ABS_FRAME_NUMBER);
    *(uint32_t *)(&msg->cb[0]) = osmo_load32be(val);
    ```

To view, visit change 34133. To unsubscribe, or for help writing mail filters, visit settings.