Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 )
Change subject: bankd: Add GSMTAP functionality for SIM traffic ......................................................................
Patch Set 2:
(2 comments)
File src/bankd/gsmtap.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/ef0283cc_9cdb2bbb PS2, Line 28: osmo_bankd_gsmtap_init
No problem. […]
AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2.so, so they are correctly named as it's public ABI of a shared osmocom library.
The question is now whether we'd want to simply link remsim-bankd against libosmo-simtrace2.so rather than copy+pasting the code. Right now only remsim-client links against that library, as it neesd to talk to the actual simtrace2 hardware.
Thinking about it, I think we don't want to link the bankd against libosmo-simtrace2, even if it means duplicating some code. If it makes sense all, we might introduce some SIM specific helper function to libosmocore/src/gsmtap.c.
https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/b54ab0ae_00feb58b PS2, Line 35: perror("unable to open GSMTAP");
Will do. […]
thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then.
-
laforge