Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 2: (2 comments) File src/bankd/gsmtap.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/ef0283cc_9cdb2bbb PS2, Line 28: osmo_bankd_gsmtap_init AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2.so, so they are correctly named as it's public ABI of a shared osmocom library. The question is now whether we'd want to simply link remsim-bankd against libosmo-simtrace2.so rather than copy+pasting the code. Right now only remsim-client links against that library, as it neesd to talk to the actual simtrace2 hardware. Thinking about it, I think we don't want to link the bankd against libosmo-simtrace2, even if it means duplicating some code. If it makes sense all, we might introduce some SIM specific helper function to libosmocore/src/gsmtap.c. https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/b54ab0ae_00feb58b PS2, Line 35: perror("unable to open GSMTAP"); thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:50:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: comment