Attention is currently required from: jtavares.

View Change

2 comments:

• File src/bankd/gsmtap.c:

  • Patch Set #2, Line 28: osmo_bankd_gsmtap_init

    No problem. […]

    AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2.so, so they are correctly named as it's public ABI of a shared osmocom library.

    The question is now whether we'd want to simply link remsim-bankd against libosmo-simtrace2.so rather than copy+pasting the code. Right now only remsim-client links against that library, as it neesd to talk to the actual simtrace2 hardware.

    Thinking about it, I think we don't want to link the bankd against libosmo-simtrace2, even if it means duplicating some code. If it makes sense all, we might introduce some SIM specific helper function to libosmocore/src/gsmtap.c.

  • Patch Set #2, Line 35: perror("unable to open GSMTAP");

    Will do. […]

    thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then.

To view, visit change 30139. To unsubscribe, or for help writing mail filters, visit settings.