Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email )

Change subject: dfu: rewrite firmware downloading ......................................................................

Patch Set 2:

(2 comments)

File usb_start.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/fec43c96_70cd59ec... : PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */

is this related to the changes in this commit?

the fixme or the lines above? Maybe I can improve the dfu_download_ffset / length -> they should be within the flash region, but not sure if flash_write will also handle those.

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/e45fb764_6a6cd6d3... : PS2, Line 178: CRITICAL_SECTION_ENTER();

why do you need the critical section here exactly? to increment dfu_download_offset?

yes, for dfu_download_offset and to ensure `dfu_flash_done = true` isn't set without dfu_flash_status.