Attention is currently required from: pespin.

View Change

2 comments:

• File usb_start.c:

  • Patch Set #2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */

    is this related to the changes in this commit?

    the fixme or the lines above?
    Maybe I can improve the dfu_download_ffset / length -> they should be within the flash region, but not sure if flash_write will also handle those.

  • Patch Set #2, Line 178: CRITICAL_SECTION_ENTER();

    why do you need the critical section here exactly? to increment dfu_download_offset?

    yes, for dfu_download_offset and to ensure `dfu_flash_done = true` isn't set without dfu_flash_status.

To view, visit change 42174. To unsubscribe, or for help writing mail filters, visit settings.