Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email )
Change subject: sip: tweak failure reporting for SIP messages ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File sip/SIP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415/comment/cbd7d03c_8cd12... PS1, Line 195: og("FAIL: expected SIP message ", sip_expect); : setverdict(fail, "Received unexpected SIP message");
see log2str() in code.
Yeah, "f_shutdown(__FILE__, __LINE__, fail, log2str(...))" is the usual construct. If logging ahead of setverdict is useful for some reason, then we might also shift that into the f_shutdown() helper function to avoid duplicate statements like here. Not a blocker herer, but might warrant some general cleanup
-
laforge