Attention is currently required from: neels, pespin.

Patch set 2:Code-Review +1

View Change

1 comment:

• File sip/SIP_Tests.ttcn:

  • Patch Set #1, Line 195:

    og("FAIL: expected SIP message ", sip_expect);
    		setverdict(fail, "Received unexpected SIP message");
    

    see log2str() in code.

    Yeah, "f_shutdown(__FILE__, __LINE__, fail, log2str(...))" is the usual construct. If logging ahead of setverdict is useful for some reason, then we might also shift that into the f_shutdown() helper function to avoid duplicate statements like here. Not a blocker herer, but might warrant some general cleanup

To view, visit change 34415. To unsubscribe, or for help writing mail filters, visit settings.