Attention is currently required from: falconia, neels.

pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email )

Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Patchset:

PS2: Idea: It may make sense at some point to get rid of such VTY comamnd and somehow be able to specify specific GSM RTP HR format over MGCP. There may even be a ticket abotu thtat iirc?

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/28545f3b_7080b89d?usp=... : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) { I'd say better split this line into 2.

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/18d1bec3_b81f2fb6?usp=... : PS2, Line 1666: mgcp_conn_watchdog_kick(conn_src->conn); It probably makes sense to call this even if output is wrong, but not a hard opinion.