Attention is currently required from: falconia, neels.
Patch set 2:Code-Review +1
3 comments:
Patchset:
Idea: It may make sense at some point to get rid of such VTY comamnd and somehow be able to specify specific GSM RTP HR format over MGCP. There may even be a ticket abotu thtat iirc?
File src/libosmo-mgcp/mgcp_network.c:
Patch Set #2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) {
I'd say better split this line into 2.
Patch Set #2, Line 1666: mgcp_conn_watchdog_kick(conn_src->conn);
It probably makes sense to call this even if output is wrong, but not a hard opinion.
To view, visit change 39869. To unsubscribe, or for help writing mail filters, visit settings.