Attention is currently required from: laforge, pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email )

Change subject: Use osmocom gtplib pointing to newer version of code ......................................................................

Patch Set 3:

(3 comments)

File rebar.config:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/a81cf836_09187... PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}}, wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time

File rebar.lock:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/4ad6f843_7e95a... PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}}, * unrelated change * just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master?

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/faf6a3b2_b5b96... PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git", unrelated change (unlike gitlab, there is no git redirect if using github urls without .git)