Attention is currently required from: laforge, pespin.

View Change

3 comments:

• File rebar.config:

  • Patch Set #3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}},

    wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time

• File rebar.lock:

  • Patch Set #3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}},

    • unrelated change
    • just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master?

  • Patch Set #3, Line 37: {git,"https://github.com/uwiger/parse_trans.git",

    unrelated change (unlike gitlab, there is no git redirect if using github urls without .git)

To view, visit change 36052. To unsubscribe, or for help writing mail filters, visit settings.