Attention is currently required from: laforge, pespin.
View Change
3 comments:
File rebar.config:
Patch Set #3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}},
wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time
File rebar.lock:
Patch Set #3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}},
- unrelated change
- just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master?
Patch Set #3, Line 37: {git,"https://github.com/uwiger/parse_trans.git",
unrelated change (unlike gitlab, there is no git redirect if using github urls without .git)
To view, visit change 36052. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308
Gerrit-Change-Number: 36052
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: lynxis lazus <lynxis@fe80.eu>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Feb 2024 09:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment