Attention is currently required from: neels, pespin. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email ) Change subject: forward SDP between SIP and MNCC ...................................................................... Patch Set 9: Code-Review-1 (1 comment) File src/sip.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222/comment/18a0a1f8_2d… PS9, Line 549: SIPTAG_PAYLOAD_STR(sdp), I'm slightly concerned about introducing the sending of SDP with the 180. It's not something I really ever see, and although some quick investigation suggests that UAs /should/ treat it like a 183, that is to say, we are telling the remote to expect early media (which come to think of it, are we? are generating ringback?) - I did come across a CISCO doc just now saying this behaviour is configurable. uf... I'd say leave the 180 without SDP. Actually, I just tested this, with an A leg hitting Freeswitch and the B leg towards osmo-sip-connector and indeed; no ringback from Freewitch as FS sees the SDP with the 180 and starts forwarding the media to the A leg, but nothing is generating ringback. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I3df5d06f38ee2d122706a9ebffde7db4f2bd6bae Gerrit-Change-Number: 16222 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Sep 2023 05:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment