Attention is currently required from: neels, pespin.

Patch set 9:Code-Review -1

View Change

1 comment:

• File src/sip.c:

  • Patch Set #9, Line 549: SIPTAG_PAYLOAD_STR(sdp),

    I'm slightly concerned about introducing the sending of SDP with the 180. It's not something I really ever see, and although some quick investigation suggests that UAs /should/ treat it like a 183, that is to say, we are telling the remote to expect early media (which come to think of it, are we? are generating ringback?) - I did come across a CISCO doc just now saying this behaviour is configurable. uf...

    I'd say leave the 180 without SDP.

    Actually, I just tested this, with an A leg hitting Freeswitch and the B leg towards osmo-sip-connector and indeed; no ringback from Freewitch as FS sees the SDP with the 180 and starts forwarding the media to the A leg, but nothing is generating ringback.

To view, visit change 16222. To unsubscribe, or for help writing mail filters, visit settings.