Attention is currently required from: daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33686 ) Change subject: osmo_io: Add function to change the maximum length of the tx_queue ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33686/comment/6f1c5773_11b19393 PS2, Line 545: g (end in a dot for doxygen AUTO_BRIEF) https://gerrit.osmocom.org/c/libosmocore/+/33686/comment/f5292165_0abbe2ec PS2, Line 549: void osmo_iofd_set_txqueue_max_length(struct osmo_io_fd *iofd, unsigned int size) (i find mildly curious mixing of "max_length" and "size" and "maximum size" terms, would rather stick to the identical name 'max_length' also for the function arg) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3d1de8bffe1123002515878655ea9e02b482888 Gerrit-Change-Number: 33686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 21:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment