Attention is currently required from: daniel.
Patch set 2:Code-Review +1
View Change
2 comments:
File src/core/osmo_io.c:
Patch Set #2, Line 545: g
(end in a dot for doxygen AUTO_BRIEF)
Patch Set #2, Line 549: void osmo_iofd_set_txqueue_max_length(struct osmo_io_fd *iofd, unsigned int size)
(i find mildly curious mixing of "max_length" and "size" and "maximum size" terms, would rather stick to the identical name 'max_length' also for the function arg)
To view, visit change 33686. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If3d1de8bffe1123002515878655ea9e02b482888
Gerrit-Change-Number: 33686
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jul 2023 21:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment