Attention is currently required from: laforge.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email )

Change subject: osmo-io: Put together message buffers when dequeued from tx queue ......................................................................

Patch Set 4:

(1 comment)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/40760/comment/2ec59388_27c8ad09?u... : PS3, Line 261: * There can be empty buffers, when a msghdr is queued to the front with incomplete write. */

do we have some unit test coverage for those rather hard-to-trigger code paths? I think it's hard to […]

I tried to trigger an incomplete write, so that it is re-queued in front of the tx_queue. With regular non-nblocking IO it is possible to have partly written buffers, but with io_uring this seems not to happen. This means that this condition is never true, as there is no msghdr with unused write buffers in front of another msghdr.

I prefer to remove it, since it is just an optimization. It is not required, even if io_uring would return an incomplete write.