Attention is currently required from: laforge.

View Change

1 comment:

• File src/core/osmo_io.c:

  • Patch Set #3, Line 261: * There can be empty buffers, when a msghdr is queued to the front with incomplete write. */

    do we have some unit test coverage for those rather hard-to-trigger code paths? I think it's hard to […]

    I tried to trigger an incomplete write, so that it is re-queued in front of the tx_queue. With regular non-nblocking IO it is possible to have partly written buffers, but with io_uring this seems not to happen. This means that this condition is never true, as there is no msghdr with unused write buffers in front of another msghdr.

    I prefer to remove it, since it is just an optimization. It is not required, even if io_uring would return an incomplete write.

To view, visit change 40760. To unsubscribe, or for help writing mail filters, visit settings.