Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30157 )

Change subject: osmux: Rotate over available Osmux CID when allocating a new one ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/975b13fa_5c37d7cd PS1, Line 748: start_j = next_free_osmux_cid_lookup & 0x07;

Since anyway the code it's doing bitwise stuff on the bitmask with i and j I thought it's understand […]

It didn't immediately occur to me, but no strong opinion. Then I'd suggest to replace the i*8 with a>>3 below to keep it consistent.

In any case +1 from me

https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/8a734b18_d851a443 PS1, Line 771: (i * 8) here