Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_osmux.c:

  • Patch Set #1, Line 748: start_j = next_free_osmux_cid_lookup & 0x07;

    Since anyway the code it's doing bitwise stuff on the bitmask with i and j I thought it's understand […]

    It didn't immediately occur to me, but no strong opinion. Then I'd suggest to replace the i*8 with a>>3 below to keep it consistent.

    In any case +1 from me

  • Patch Set #1, Line 771: (i * 8)

    here

To view, visit change 30157. To unsubscribe, or for help writing mail filters, visit settings.