fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32537 )
Change subject: bts_is_online(): make the BTS pointer const, return bool ......................................................................
bts_is_online(): make the BTS pointer const, return bool
Change-Id: Idb4f9f8862041c5902df0e6e8d1ac2a60ada95df --- M src/osmo-bsc/bts.c 1 file changed, 12 insertions(+), 3 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 108c355..527220f 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -888,14 +888,14 @@ return (base->depends_on[idx] & (1U << bit)) > 0; }
-static int bts_is_online(struct gsm_bts *bts) +static bool bts_is_online(const struct gsm_bts *bts) { /* TODO: support E1 BTS too */ if (!is_ipaccess_bts(bts)) - return 1; + return true;
if (!bts->oml_link) - return 0; + return false;
return bts->mo.nm_state.operational == NM_OPSTATE_ENABLED; }