fixeria submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved
bts_is_online(): make the BTS pointer const, return bool

Change-Id: Idb4f9f8862041c5902df0e6e8d1ac2a60ada95df
---
M src/osmo-bsc/bts.c
1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 108c355..527220f 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -888,14 +888,14 @@
return (base->depends_on[idx] & (1U << bit)) > 0;
}

-static int bts_is_online(struct gsm_bts *bts)
+static bool bts_is_online(const struct gsm_bts *bts)
{
/* TODO: support E1 BTS too */
if (!is_ipaccess_bts(bts))
- return 1;
+ return true;

if (!bts->oml_link)
- return 0;
+ return false;

return bts->mo.nm_state.operational == NM_OPSTATE_ENABLED;
}

To view, visit change 32537. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idb4f9f8862041c5902df0e6e8d1ac2a60ada95df
Gerrit-Change-Number: 32537
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged